Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sentry-fastapi integration, expose sampling rate #15550

Merged
merged 1 commit into from Feb 10, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Feb 10, 2023

That's the recommended way for FastAPI apps (https://docs.sentry.io/platforms/python/guides/quart/configuration/integrations/asgi/, https://docs.sentry.io/platforms/python/guides/fastapi/). Like #15548 it only adds extra information on ASGI routes.
Also exposes the traces_sample_rate setting for potential performance measurement details:

sentry

perf

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek force-pushed the use_sentry_fastapi_integration branch from c3a6fb9 to a31eb04 Compare February 10, 2023 12:03
@natefoo natefoo merged commit d94f1f6 into galaxyproject:dev Feb 10, 2023
@nsoranzo nsoranzo changed the title [23.0] Use sentry-fastapi integration, expose sampling rate Use sentry-fastapi integration, expose sampling rate Feb 10, 2023
@nsoranzo
Copy link
Member

The "Test Galaxy Packages" build failure was a real one here, this build is now failing on the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants