read job_conf directly from config_dir instead of computing it again from config_file
#15596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should be the same as `os.path.dirname(self.app.config.config_file)` but `config_dir` is computed anyway in the config module
nsoranzo
approved these changes
Feb 16, 2023
jdavcs
reviewed
Feb 16, 2023
jdavcs
approved these changes
Feb 16, 2023
nsoranzo
reviewed
Feb 16, 2023
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
nsoranzo
approved these changes
Feb 16, 2023
|
Thank you, @bernt-matthias! (we should have merged this months ago!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config_dirshould be the same asos.path.dirname(self.app.config.config_file)butconfig_diris computed anyway in the config moduleHow to test the changes?
(Select all options that apply)
License