Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor hid display tweak #15662

Merged
merged 2 commits into from Mar 2, 2023
Merged

Minor hid display tweak #15662

merged 2 commits into from Mar 2, 2023

Conversation

dannon
Copy link
Member

@dannon dannon commented Feb 28, 2023

Just feels a bit more natural without the space before the colon.

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.1 milestone Feb 28, 2023
@mvdbeek
Copy link
Member

mvdbeek commented Feb 28, 2023

    Expected substring: "8 : M117C1-ch_2.fq.fastqsanger"
    Received string:    "8: M117C1-ch_2.fq.fastqsanger"

otherwise looks good

@dannon
Copy link
Member Author

dannon commented Feb 28, 2023

Yeah, figured I'd need to update a test or two -- will follow up in a minute. Thanks!

@dannon
Copy link
Member Author

dannon commented Mar 2, 2023

Updated the two tests that needed it for the new format; integration test passes locally and is waiting on something in a different interface.

@dannon dannon merged commit 84cb890 into galaxyproject:dev Mar 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

This PR was merged without a "kind/" label, please correct.

@nsoranzo
Copy link
Member

nsoranzo commented Mar 3, 2023

It seems this broke 2 Selenium tests on dev?

FAILED lib/galaxy_test/selenium/test_history_dataset_state.py::TestHistoryDatasetState::test_dataset_state - AssertionError: 1:
FAILED lib/galaxy_test/selenium/test_history_dataset_state.py::TestHistoryDatasetState::test_dataset_change_dbkey - AssertionError: 1:

@dannon
Copy link
Member Author

dannon commented Mar 3, 2023

@nsoranzo I'll take a look; I thought I had addressed the only failing test here. (oof -- I may have fixed one of two selenium suite failures; I'll follow up in a quick PR)

@dannon dannon mentioned this pull request Mar 3, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants