Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transactional state to workflow scheduling manager #15683

Merged
merged 2 commits into from Mar 2, 2023
Merged

Add transactional state to workflow scheduling manager #15683

merged 2 commits into from Mar 2, 2023

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Mar 2, 2023 •
edited

Ref #12541

Solve same type of issue as in #15671.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs
Add transaction state to workflow scheduling; use engine
57a4b20 
No need for a Session >> less overhead.
Also, use SQLAlchemy 2.0-compatible syntax.
@jdavcs
Wrap attempt_schedule in a transaction
672913b
@jdavcs jdavcs added kind/refactoring cleanup or refactoring of existing code, no functional changes area/database Galaxy's database or data access layer labels Mar 2, 2023
@jdavcs jdavcs added this to the 23.1 milestone Mar 2, 2023
@jdavcs jdavcs marked this pull request as ready for review March 2, 2023 05:52
@jdavcs jdavcs requested review from jmchilton and mvdbeek March 2, 2023 05:54
@mvdbeek mvdbeek merged commit e5eada3 into galaxyproject:dev Mar 2, 2023
@mvdbeek
Copy link
Member

mvdbeek commented Mar 2, 2023

Thanks @jdavcs !

@jdavcs jdavcs mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton Awaiting requested review from jmchilton

@mvdbeek mvdbeek Awaiting requested review from mvdbeek

Assignees
No one assigned
Labels
area/database Galaxy's database or data access layer kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
23.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdavcs @mvdbeek