Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0] Add support for launching workflows via Tutorial Mode #15684

Merged
merged 12 commits into from May 3, 2023
Merged

[23.0] Add support for launching workflows via Tutorial Mode #15684

merged 12 commits into from May 3, 2023

Conversation

hexylena
Copy link
Member

@hexylena hexylena commented Mar 2, 2023 •
edited

This copies and pastes the code for auto-loading tools, and adds support for elements marked up as workflows

How to test the changes?

(Select all options that apply)

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@hexylena hexylena added this to the 23.0 milestone Mar 2, 2023
@hexylena hexylena requested a review from dannon March 2, 2023 09:13
@hexylena
Copy link
Member Author

hexylena commented Mar 2, 2023

fyi @shiltemann @bebatut @nomadscientist, soon "click to run workflow" will be just as easy as "click to run tool"

@nomadscientist
Copy link
Contributor

fyi @shiltemann @bebatut @nomadscientist, soon "click to run workflow" will be just as easy as "click to run tool"

Say what? That's amazeballs

@hexylena hexylena force-pushed the gtn-trs branch 2 times, most recently from 4f4b1ef to ced79bd Compare March 2, 2023 09:59
@hexylena hexylena mentioned this pull request Mar 2, 2023
Merged
mvdbeek
mvdbeek reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the importance and the regularity with which the hooks get broken it's probably worth adding selenium tests for this.

config/plugins/webhooks/gtn/script.js Outdated Show resolved Hide resolved
config/plugins/webhooks/gtn/script.js Outdated Show resolved Hide resolved
@hexylena
Copy link
Member Author

hexylena commented Mar 2, 2023

Given the importance and the regularity with which the hooks get broken it's probably worth adding selenium tests for this.

yeah I can add that. good suggestion

@dannon dannon changed the title Add support for importing workflows via Tutorial Mode [23.0] Add support for importing workflows via Tutorial Mode Mar 2, 2023
@hexylena hexylena changed the title [23.0] Add support for importing workflows via Tutorial Mode [23.0] Add support for launching workflows via Tutorial Mode Mar 2, 2023
@hexylena
Copy link
Member Author

hexylena commented Mar 2, 2023

I'm writing a brief test, but, the important parts to execute require the setup of the proxy, or they're non-functional. I don't suppose we have a good way to include an http proxy for test cases?

@mvdbeek
Copy link
Member

mvdbeek commented Mar 2, 2023

What did we need the proxy for again ?

@hexylena
Copy link
Member Author

hexylena commented Mar 2, 2023

So that the iframe is on the same domain, and not subject to restrictions. This is when e.g. the buttons become clickable (and the routing is triggered).

@dannon dannon force-pushed the gtn-trs branch 2 times, most recently from d554f94 to 9645a6b Compare April 6, 2023 03:24
@hexylena
Copy link
Member Author

@dannon is this missing anything else from your side? anything you need me to do here?

@dannon
Copy link
Member

dannon commented Apr 25, 2023 •
edited

I don't think it is but I haven't looked at it in a bit. Want to kick the tires one more time to make sure it still works like you expected and we'll merge it?

Ahh, there are a couple unresolved comments about the use of var; I'll take another quick look locally.

@dannon dannon mentioned this pull request May 2, 2023
Closed
@hexylena
Copy link
Member Author

hexylena commented May 2, 2023 •
edited

yeah I can do that tomorrow @dannon , especially in the context of #15684 (comment), I want to be sure it's right.

@hexylena
Copy link
Member Author

hexylena commented May 3, 2023

@dannon with 096ed7b I can confirm this all works, it was just one leftover jquery style access, but it's tested locally and I'm happy! Thank you so much for all of the rewrites and clean up commits!

@dannon dannon merged commit 0aff863 into galaxyproject:release_23.0 May 3, 2023
33 of 35 checks passed
@github-actions
Copy link

github-actions bot commented May 3, 2023

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannon dannon dannon left review comments

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/enhancement
Projects
None yet
Milestone
23.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hexylena @nomadscientist @mvdbeek @dannon @nsoranzo