[23.0] Fix Short Term Storage cleanup when metadata is lost #15724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or skip if the whole directory is gone.
mvdbeek
reviewed
Mar 7, 2023
mvdbeek
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15722
If the metadata file is lost for some reason, the STS request directory will be deleted. If this is too much, we can just skip the deletion and log a warning, but since these files are temporal by design maybe is good enough just to remove them.
This situation is unlikely to happen unless there is an error writing the metadata file or some files/directories were manually removed.
How to test the changes?
License