Fix/Enhance recalculate disk usage API endpoint #15739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will follow up with the DiskUsageSummary component modernization in a different PR. |
davelopez
force-pushed
the
fix_recalculate_disk_usage
branch
from
9f81176
to
4137b43
Compare
davelopez
force-pushed
the
fix_recalculate_disk_usage
branch
from
22fc905
to
6b5b2b4
Compare
|
The integration test failure is legit https://github.com/galaxyproject/galaxy/actions/runs/4365262789/jobs/7633649104 |
jmchilton
reviewed
Mar 9, 2023
jmchilton
approved these changes
Mar 10, 2023
|
Can you rebase this? |
And deprecate the old one.
davelopez
force-pushed
the
fix_recalculate_disk_usage
branch
from
fb3e291
to
860b4c0
Compare
|
Awesome - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix (affects only dev)
The
recalculate_user_disk_usagetask has the required object store instance now.Enhancements
/api/users/current/recalculate_disk_usageto be more consistent with other endpoints affecting the current user. The old one has been marked as deprecated.AsyncTaskResultSummarywhen Celery is enabled to be able to track the status of the task if necessary.How to test the changes?
License