Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0] Fix Worflow editor loading issues #15750

Merged
merged 3 commits into from Mar 9, 2023
Merged

[23.0] Fix Worflow editor loading issues #15750

merged 3 commits into from Mar 9, 2023

Conversation

ElectronicBlueberry
Copy link
Member

watchEffect was triggering recursive reactivity. Chaining it to watch seems to have fixed the issue.
Waiting for tests to check if this has unintended side-effects.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ElectronicBlueberry
make isMappedOver composable
91fdd7b 
remove console.log
@ElectronicBlueberry @mvdbeek
use store to determine mapped over state
37e746c 
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
@ElectronicBlueberry ElectronicBlueberry marked this pull request as ready for review March 9, 2023 12:36
@github-actions github-actions bot added this to the 23.0 milestone Mar 9, 2023
mvdbeek
mvdbeek approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ElectronicBlueberry!

@mvdbeek mvdbeek merged commit 8b77750 into galaxyproject:release_23.0 Mar 9, 2023
@mvdbeek mvdbeek mentioned this pull request Mar 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/bug
Projects
None yet
Milestone
23.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ElectronicBlueberry @mvdbeek