Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22.01] add security checks to page and visualization APIs #15826

Merged
merged 1 commit into from
Mar 20, 2023
Merged

[22.01] add security checks to page and visualization APIs #15826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/galaxy/webapps/galaxy/controllers/page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,9 @@ def list(self, trans, *args, **kwargs):
operation = kwargs['operation'].lower()
ids = util.listify(kwargs['id'])
for id in ids:
item = session.query(model.Page).get(self.decode_id(id))
if operation == "delete":
item = session.query(model.Page).get(self.decode_id(id))
self.security_check(trans, item, check_ownership=True)
item.deleted = True
session.flush()

Expand Down Expand Up @@ -393,6 +394,7 @@ def edit(self, trans, payload=None, **kwd):
decoded_id = self.decode_id(id)
user = trans.get_user()
p = trans.sa_session.query(model.Page).get(decoded_id)
p = self.security_check(trans, p, check_ownership=True)
if trans.request.method == 'GET':
if p.slug is None:
self.slug_builder.create_item_slug(trans.sa_session, p)
Expand Down
6 changes: 3 additions & 3 deletions lib/galaxy/webapps/galaxy/controllers/visualization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,8 @@ def list(self, trans, **kwargs):
operation = kwargs['operation'].lower()
ids = util.listify(kwargs['id'])
for id in ids:
item = session.query(model.Visualization).get(self.decode_id(id))
if operation == "delete":
item = self.get_visualization(trans, id)
item.deleted = True
if operation == "copy":
self.copy(trans, **kwargs)
Expand Down Expand Up @@ -327,7 +327,7 @@ def index(self, trans, *args, **kwargs):
@web.expose
@web.require_login()
def copy(self, trans, id, **kwargs):
visualization = self.get_visualization(trans, id, check_ownership=False)
visualization = self.get_visualization(trans, id, check_ownership=False, check_accessible=True)
user = trans.get_user()
owner = (visualization.user == user)
new_title = f"Copy of '{visualization.title}'"
Expand Down Expand Up @@ -390,7 +390,7 @@ def imp(self, trans, id):

# Do import.
session = trans.sa_session
visualization = self.get_visualization(trans, id, check_ownership=False)
visualization = self.get_visualization(trans, id, check_ownership=False, check_accessible=True)
if visualization.importable is False:
return trans.show_error_message(f"The owner of this visualization has disabled imports via this link.<br>You can {referer_message}", use_panels=True)
elif visualization.deleted:
Expand Down