merge release_23.0 into dev

[martenson]

resolved some conflict in code from @mvdbeek @jmchilton -- please sanity check

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[jmchilton]

Sanity checked unless CI reveals I am wrong.

[martenson]

There is an issue in compiling .ts that I'd expect to work with duck typing but it does not seem to be the case.

details: The shallow clone of const step = { ...stepStore.getStep(stepId.value) }; somehow does not match the expected type for step.id. Why?

[ElectronicBlueberry]

step.id for const step = ... is of type number | undefined, since getStep potentially returns undefined.

Due to the object being spread here, if getStep returns undefined, step will be an empty object, which can not be caught by assertDefined. This leads to step.id remaining potentially undefined after the assertion.

The spread must be preformed after the assertion, so that this potential error can be caught.

    let step = stepStore.getStep(stepId.value);
    assertDefined(step);
    step = { ...step };

or, a bit safer

    const sourceStep = stepStore.getStep(stepId.value);
    assertDefined(sourceStep);
    const step = { ...sourceStep };

[martenson]

the rest of the test fails do not seem relevant to this merge -- I'm going forward with it