Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 22.01 -> 22.05 #15850

Merged
merged 11 commits into from
Mar 28, 2023
Merged

Merge 22.01 -> 22.05 #15850

merged 11 commits into from
Mar 28, 2023

Conversation

dannon
Copy link
Member

@dannon dannon commented Mar 27, 2023

ping @jdavcs for perusal of the maintenance script changes that conflicted.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon
Copy link
Member Author

dannon commented Mar 27, 2023

(this is not right, yet -- see joinedload/eagerload issues in scripts/cleanup_datasets/cleanup_datasets.py)

Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, these commits explain the conflict (now resolved):

3/20/22: Updated SQLAlchemy syntax on [dev]
158b9f0

12/17/22: Fixed bug on [22.01]
dd553e8

@dannon dannon closed this Mar 27, 2023
@dannon dannon reopened this Mar 27, 2023
@dannon dannon added the merge label Mar 27, 2023
@dannon
Copy link
Member Author

dannon commented Mar 28, 2023

I'm going to go ahead and merge this in; none of it looks related to the changes anymore after applying black to the forward merge, and other PRs against 22.05 have similar failures.

@dannon dannon merged commit 5300b13 into galaxyproject:release_22.05 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants