Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show backend search errors in hist panel #15874

Merged

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Mar 30, 2023

Currently, if a history panel search is performed and there is an error returned from the backend for an invalid filter/value, we do not show the error to the user. Added an error message to the history listing view as well an indicator in the advanced filters field that produced the backend error.

Screen.Recording.2023-05-04.at.3.19.15.PM.mov

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Copy link
Member

mvdbeek commented May 2, 2023

I think that's a really cool enhancement, can you resolve the conflicts and see if there's an alternative to the autofocus tag ?

@ahmedhamidawan ahmedhamidawan force-pushed the show_backend_error_in_hist_panel branch from 03cdefd to 99140d5 Compare May 3, 2023 21:24
@ahmedhamidawan ahmedhamidawan marked this pull request as ready for review May 6, 2023 21:41
@github-actions github-actions bot added this to the 23.1 milestone May 6, 2023
@ahmedhamidawan
Copy link
Member Author

Failing test is passing locally, seems unrelated

@martenson martenson changed the title Show backend errors in hist panel Show backend search errors in hist panel May 8, 2023
@martenson
Copy link
Member

Nice, thanks @ahmedhamidawan !

@martenson martenson merged commit 3b38e91 into galaxyproject:dev May 8, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants