Enable per-destination container_resolver_config_file
#15884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernt-matthias
force-pushed
the
fix/per-destination-container-resolver-file
branch
from
c9e1446
to
37a28d0
Compare
- per destination container_resolvers per `container_resolvers_config_file` did not work because `ContainerFinder` did not check if this key is set in the `destination_info` (but only `container_resolvers`) this is crucial for job configuration using XML - per destination container_resolvers did not work if a global config was given with `container_resolvers` and per destination config used `container_resolvers_config_file` and there was one f missing in an f-string
bernt-matthias
force-pushed
the
fix/per-destination-container-resolver-file
branch
2 times, most recently
from
b04babe
to
89cc0f1
Compare
bernt-matthias
changed the title
container_resolver_config_file
bernt-matthias
force-pushed
the
fix/per-destination-container-resolver-file
branch
from
ad9f57c
to
ac91975
Compare
from a file (with global container config configured at the same time)
|
This doesn't seem to be a fix ? I don't think it was meant to work this way. Otherwise I guess this is fine. |
mvdbeek
approved these changes
Apr 3, 2023
mvdbeek
changed the title
container_resolver_config_filecontainer_resolver_config_file
|
Thanks for having a look :) |
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
container_resolvers_config_filedid not work becauseContainerFinderdid not check if this key is set in thedestination_info(but onlycontainer_resolvers) this is crucial for job configuration using XMLcontainer_resolversand per destination config usedcontainer_resolvers_config_fileWhy this is needed / how I stumbled over this: Finally had an idea for migrating to containers on my site: I will define a
cached_explicit_singularity,cached_mulled_singularity, i.e. this will only pick up containers that have been cached. tools that do not have a container installed will fall back to condacached_explicit_singularity,cached_mulled_singularity,mulled_singularitywhich allows me to pull containers via AdminUI / APIUnfortunately my job config is still XML, so I need
container_resolvers_config_filefor the per destination config.If someone wants to have this backported then I can do. For me it's fine to carry the single commit in my deployment branch for 1 release.
How to test the changes?
(Select all options that apply)
License