Allow pending inputs in some collection operation tools #15892
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those tools where it makes sense. We can't of course do this for tools that filter outputs based on dataset size or dataset state, or tools that make decisions based on extra datasets (e.g text files with new identifiers or tags).
As mentioned inline, we could allow more tools to run with pending input collections, but that doesn't work if we need to read an additional file from disk. To be more flexible for those cases we could add more special casing or we could let the job handler loop handle the waiting for datasets for us, neither of which seems worth doing right now.
Does a bit of what is requested in #15879
How to test the changes?
(Select all options that apply)
License