Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pending inputs in some collection operation tools #15892

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Apr 3, 2023

For those tools where it makes sense. We can't of course do this for tools that filter outputs based on dataset size or dataset state, or tools that make decisions based on extra datasets (e.g text files with new identifiers or tags).

As mentioned inline, we could allow more tools to run with pending input collections, but that doesn't work if we need to read an additional file from disk. To be more flexible for those cases we could add more special casing or we could let the job handler loop handle the waiting for datasets for us, neither of which seems worth doing right now.

Does a bit of what is requested in #15879

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

For those tools where it makes sense. We can't of course do this for
tools that filter outputs based on dataset size or dataset state,
or tools that make decisions based on extra datasets (e.g text files
with new identifiers).
Copy link
Contributor

@assuntad23 assuntad23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@davelopez davelopez merged commit e11b56d into galaxyproject:dev Apr 4, 2023
39 checks passed
@davelopez
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants