Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22.05] merge 22.01 #15896

Merged
merged 3 commits into from Apr 5, 2023
Merged

[22.05] merge 22.01 #15896

merged 3 commits into from Apr 5, 2023

Conversation

bernt-matthias
Copy link
Contributor

#15893

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

bernt-matthias and others added 2 commits April 4, 2023 12:09
@bernt-matthias
cached_explicit_singularity: copy container description
e81fc67 
otherwise `container_description.identifier = cache_path` (at the end of the function)
will modify the original (i.e. the tools) container description which influences
i.e. (may break) successive container resolutions.
@mvdbeek
Merge pull request galaxyproject#15893 from bernt-matthias/fix/cached…
f76d894 
…_explicit_singularity_container_description

[22.01] cached_explicit_singularity: needs to copy container description
@github-actions github-actions bot added this to the 23.0 milestone Apr 4, 2023
@bernt-matthias bernt-matthias marked this pull request as draft April 4, 2023 15:25
@bernt-matthias
Copy link
Contributor Author

bernt-matthias commented Apr 4, 2023 •
edited

Please do not merge .. I have another one

Will keep it as is at the moment... so good to go

@bernt-matthias bernt-matthias marked this pull request as ready for review April 4, 2023 15:43
@mvdbeek mvdbeek merged commit f420a61 into galaxyproject:release_22.05 Apr 5, 2023
32 of 38 checks passed
@mvdbeek mvdbeek added the merge label Apr 5, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/tool-dependencies area/tool-framework merge
Projects
None yet
Milestone
23.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bernt-matthias @mvdbeek