Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Fix defineProps warning in client build. #15930

Merged
merged 1 commit into from Apr 12, 2023

Conversation

dannon
Copy link
Member

@dannon dannon commented Apr 12, 2023

Fixes warning in build about defineProps being a compiler macro and no longer needs to be imported. Just a warning, no error/harm, but targeting 23.0 to eliminate it as a source of confusion.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon added the minor label Apr 12, 2023
@github-actions github-actions bot added this to the 23.0 milestone Apr 12, 2023
@davelopez davelopez merged commit 4811b8d into galaxyproject:release_23.0 Apr 12, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants