Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 23.0 into dev #15958

Merged
merged 20 commits into from
Apr 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
c43fef9
Fix History Import Bug
Apr 11, 2023
55f5fe1
Cast destination param string to bool when checking truthyness
mvdbeek Apr 12, 2023
f209574
Use 'danger' variant on error
davelopez Apr 12, 2023
3b72a57
Merge pull request #15928 from davelopez/23.0_fix_toast_color
davelopez Apr 12, 2023
fd222c6
Fix warning about defineProps being a compiler macro and no longer ne…
dannon Apr 12, 2023
4811b8d
Merge pull request #15930 from dannon/minor-warn-fix
davelopez Apr 12, 2023
b050d3d
Merge pull request #15927 from mvdbeek/fix_outputs_to_working_directo…
natefoo Apr 12, 2023
97c8776
Add basic navigation guard for anonymous
davelopez Apr 13, 2023
c53e493
Prevent anonymous access to StorageDashboard
davelopez Apr 13, 2023
7aa0817
Merge pull request #15934 from davelopez/23.0_nav_guard_anonymous
dannon Apr 14, 2023
fc6460e
Update Gravity to 1.0.3
natefoo Apr 14, 2023
a7939af
Merge pull request #15939 from natefoo/gravity-1.0.3
natefoo Apr 14, 2023
0542ebf
Add ``ca_certs option`` for sentry client
mvdbeek Apr 16, 2023
298a96d
Merge pull request #15943 from mvdbeek/ca_certs_sentry
natefoo Apr 16, 2023
dad83ff
Merge pull request #15923 from ahmedhamidawan/history_view_switching_bug
dannon Apr 17, 2023
b503ef8
Remove stray raise in library code
mvdbeek Apr 18, 2023
0fa4a06
Add test for listing contents via library contents API
mvdbeek Apr 18, 2023
1a984f2
Merge pull request #15950 from mvdbeek/fix_folder_listing
mvdbeek Apr 18, 2023
19a4426
Merge branch 'release_22.05' into release_23.0
mvdbeek Apr 19, 2023
3d836f0
Merge branch 'release_23.0' into dev
mvdbeek Apr 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@galaxyproject/galaxy-client",
"version": "0.1.0",
"version": "23.0.0",
"description": "Galaxy client application build system",
"keywords": [
"galaxy"
Expand Down
1 change: 0 additions & 1 deletion client/src/components/ClientError.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
// (AdminRequired), but could be used for other client errors that need to be
// presented to the user interrupting the normal flow and context of the app.

import { defineProps } from "vue";
import Alert from "@/components/Alert.vue";

const props = defineProps<{
Expand Down
4 changes: 3 additions & 1 deletion client/src/components/providers/UserHistories.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ export default {
return null;
},
historyModels() {
return this.histories.map((h) => Object.assign({}, h));
return this.histories
.map((h) => Object.assign({}, h))
.filter((h) => !h.user_id || h.user_id === this.user.id);
},
},
methods: {
Expand Down
2 changes: 1 addition & 1 deletion client/src/composables/toast.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const Toast = {
},

error(message: string, title = "Error") {
toastRef.value?.showToast(message, title, "error");
toastRef.value?.showToast(message, title, "danger");
},
};

Expand Down
41 changes: 32 additions & 9 deletions client/src/entry/analysis/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -504,18 +504,41 @@ export function getRouter(Galaxy) {
],
});

router.beforeEach(async (to, from, next) => {
// TODO: merge anon redirect functionality here for more standard handling

function checkAdminAccessRequired(to) {
// Check parent route hierarchy to see if we require admin access here.
// Access is required if *any* component in the hierarchy requires it.
if (to.matched.some((record) => record.meta.requiresAdmin === true)) {
const isAdmin = getGalaxyInstance()?.user?.isAdmin() || false;
if (!isAdmin) {
const error = new Error(`Administrator Access Required for '${to.path}'.`);
error.name = "AdminRequired";
next(error);
}
const isAdmin = getGalaxyInstance()?.user?.isAdmin();
return !isAdmin;
}
return false;
}

function checkRegisteredUserAccessRequired(to) {
// Check parent route hierarchy to see if we require registered user access here.
// Access is required if *any* component in the hierarchy requires it.
if (to.matched.some((record) => record.meta.requiresRegisteredUser === true)) {
const isAnonymous = getGalaxyInstance()?.user?.isAnonymous();
return isAnonymous;
}
return false;
}

router.beforeEach(async (to, from, next) => {
// TODO: merge anon redirect functionality here for more standard handling

const isAdminAccessRequired = checkAdminAccessRequired(to);
if (isAdminAccessRequired) {
const error = new Error(`Admin access required for '${to.path}'.`);
error.name = "AdminRequired";
next(error);
}

const isRegisteredUserAccessRequired = checkRegisteredUserAccessRequired(to);
if (isRegisteredUserAccessRequired) {
const error = new Error(`Registered user access required for '${to.path}'.`);
error.name = "RegisteredUserRequired";
next(error);
}
next();
});
Expand Down
1 change: 1 addition & 0 deletions client/src/entry/analysis/routes/storageDashboardRoutes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export default [
{
path: "/storage",
component: Base,
meta: { requiresRegisteredUser: true },
children: [
{
path: "",
Expand Down
4 changes: 2 additions & 2 deletions client/src/store/historyStore/historyStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
const state = {
// selected history
currentHistoryId: null,
// histories for current user
// histories for current user, can also have other user histories loaded for HistoryView
histories: {},
historiesLoading: false,
};
Expand Down Expand Up @@ -98,7 +98,7 @@ let isLoadingHistories = false;
const actions = {
async copyHistory({ dispatch }, { history, name, copyAll }) {
const newHistory = await cloneHistory(history, name, copyAll);
return dispatch("selectHistory", newHistory);
return dispatch("setCurrentHistory", newHistory.id);
},
async createNewHistory({ dispatch }) {
// create history, then select it as current at the same time
Expand Down
12 changes: 12 additions & 0 deletions doc/source/admin/galaxy_options.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2915,6 +2915,18 @@
:Type: float


~~~~~~~~~~~~~~~~~~~
``sentry_ca_certs``
~~~~~~~~~~~~~~~~~~~

:Description:
Use this option to provide the path to location of the CA
(Certificate Authority) certificate file if the sentry server uses
a self-signed certificate.
:Default: ``None``
:Type: str


~~~~~~~~~~~~~~~
``statsd_host``
~~~~~~~~~~~~~~~
Expand Down
Loading