Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build container with nodejs #15979

Merged
merged 2 commits into from Apr 24, 2023

Conversation

ksuderman
Copy link
Contributor

The galaxy-min Docker image built for Kubernetes does not include nodejs; in fact the files for node are clean up in the previous stages. This prevents the expression tools that depend on node being present from running.

This pull request performs an apt-get install nodejs in the final stage to reinstall a minimal node package. We could modify one of the previous stages to leave node installed and copy to the final image, but this seems like the easiest and cleanest way to get node installed without extraneous packages.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ksuderman ksuderman requested review from nuwang and afgane April 21, 2023 21:28
@github-actions github-actions bot added this to the 23.1 milestone Apr 21, 2023
@afgane afgane merged commit f11e4fa into galaxyproject:dev Apr 24, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants