Use Filtering class to get and set filter texts

[ahmedhamidawan]

There are several improvements to Filtering in this PR:

Using the Filtering class to apply and get filterTexts:

Instead of setting filters values like so:

setFilter("deleted:true");

Or like:

let filterText = "";
if (item.hid) {
    filterText = `hid:${item.hid}`;
    if (item.deleted) {
        filterText += " deleted:true";
    }
    if (!item.visible) {
        filterText += " visible:false";
    }
}
await this.applyFilterText(historyId, filterText);

We are now able to pass filters as objects:

const filters = {
    deleted: item.deleted,
    visible: item.visible,
    hid: item.hid,
};
await this.applyFilters(history_id, filters);

Converting the buttons in HistoryCounter to "Include deleted/visible"

The buttons in the HistoryCounter as of now work as toggles that will either show ONLY deleted items if you click the deleted button, and vice versa for the visible button
Changed this so the tooltips say "Include Deleted" instead, so users can click the buttons and include deleted or hidden items upon clicking on these buttons:

Screen.Recording.2023-05-02.at.11.22.33.PM.mov

Keeping HistoryPanel filterTextin sync with the historyStore:

Fixes #15990
We keep the current HistoryPanel and historyStore.storedFilterText in sync:

Screen.Recording.2023-04-25.at.2.35.24.PM.mov

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[davelopez]

Thank you so much @ahmedhamidawan!

This is already an awesome improvement! I'm looking forward to the next refactoring to reduce juggling around "filterText" 👍

[ahmedhamidawan]

Failed test:

FAILED test/integration_selenium/test_user_library_permissions.py::TestUserLibraryImport::test_user_library_import_dir_warning

seems unrelated