Fixes the parcel2 build for hdf5 viz when using node18. #16047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem is that parcel passes through, unfiltered, the environment. We could have a separate list to figure out which plugins need additional options, but this runs the risk of deployers having *other* potentially broken things in their ENV for node. By telling parcel to just use the process backend, we avoid this issue completely and don't have to modify or maintain other changes to the build infra.
|
Followup to #15394 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying problem is that parcel passes through, unfiltered, the environment. We could have a separate list to figure out which plugins need additional options, but this runs the risk of deployers having other potentially broken things in their ENV for node. By telling parcel to just use the process backend, we avoid this issue completely and don't have to modify or maintain other changes to the build infra.
How to test the changes?
(Select all options that apply)
License