Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor a few client object store components #16051

Merged

Conversation

jmchilton
Copy link
Member

A couple fixes but mostly refactoring and modernization related to a couple of the client pieces added in #14073 to make room for user defined object stores in #15875.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton force-pushed the refactor_object_store_components branch from 92581cc to 31a295c Compare May 5, 2023 15:46
@jmchilton jmchilton marked this pull request as ready for review May 10, 2023 13:05
@github-actions github-actions bot added this to the 23.1 milestone May 10, 2023
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
@davelopez davelopez merged commit 0c538b6 into galaxyproject:dev May 15, 2023
16 of 17 checks passed
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@davelopez davelopez added kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes labels May 15, 2023
@jmchilton
Copy link
Member Author

Thanks for the review and merge!

@nsoranzo nsoranzo deleted the refactor_object_store_components branch May 15, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants