Attempt to fix mypy check #16103
Merged
Attempt to fix mypy check #16103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galaxy/model/migrations/util.py:154: error: Too many positional arguments for
"drop_index" [misc]
op.drop_index(self.index_name, self.table_name)
github-actions
bot
added
the
area/database
|
Yes, this is the correct fix for the dev branch, I'm opening a separate PR for release_23.0, see #16099 (comment) |
|
Ohh I see, thank you Nicola! I didn't see the comment. |
nsoranzo
approved these changes
May 17, 2023
|
The PR for release_23.0 is at #16104 |
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a bit confused by the mypy error consistently failing in all PRs. It doesn't look that this should happen.
How to test the changes?
License