Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Fix rank calculation for jobs waiting to be run by anonymous users #16137

Merged
merged 1 commit into from May 23, 2023

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented May 22, 2023

As per discussion on galaxyadmin slack from May 22, 2023:

Issue: some jobs run by anonymous users get lots.
Cause: as per @natefoo:

Ok, I suspect it might be the windowed query. This would treat all anonymous users (user_id is null) as a single user: https://github.com/galaxyproject/galaxy/blob/dev/lib/galaxy/jobs/handler.py#L432

If the number of new state anonymous jobs on a given handler is larger than the window size, the ones past the cutoff would never be seen.
...
Basically we just need that rank function to use user_id if not null or session_id if user_id is null.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added this to the 23.0 milestone May 22, 2023
@jdavcs jdavcs requested a review from natefoo May 22, 2023 21:14
Copy link
Member

@natefoo natefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton @jdavcs! :shipit:

@jdavcs jdavcs merged commit 995d2d3 into galaxyproject:release_23.0 May 23, 2023
34 of 35 checks passed
@mvdbeek mvdbeek changed the title [23.0] Release 23.0 fix job rank [23.0] Fix rank calculation for jobs waiting to be run by anonymous users May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants