[23.0] Assert that local branches are up to date in release point script #16195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, test failures are unrelated, but we shouldn't have to install node via nodeenv at all. I wonder if the extra |
nuwang
approved these changes
Jun 6, 2023
jmchilton
reviewed
Jun 6, 2023
| ) | ||
| subprocess.run(["git", "checkout", base_branch], cwd=galaxy_root).check_returncode() | ||
|
|
||
|
|
||
| def push_references(references: List[str], upstream: str = "https://github.com/galaxyproject/galaxy.git"): |
There was a problem hiding this comment.
This is very clever - I missed this. In my Makefile scripts I've always had to pick a branch name - using the full path is a great idea! Thanks for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strategy is that we make sure the local branch is not before or behind the tracked remote branch (don't really know if that's the upstream given by
--upstream), and then we make sure the tip commit isn't differentHow to test the changes?
(Select all options that apply)
License