[23.1] use router instead of hard links for certain page urls #16297

martenson · 2023-06-22T17:43:07Z

prevents refreshing, improves UX

How to test the changes?

(Select all options that apply)

I've included appropriate automated tests.
This is a refactoring of components with existing test coverage.
Instructions for manual testing are as follows:
1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

client/src/components/Page/PageDropdown.vue

client/src/components/Page/PageList.vue

martenson added kind/bug area/UI-UX labels Jun 22, 2023

martenson added this to the 23.1 milestone Jun 22, 2023

guerler reviewed Jun 25, 2023

View reviewed changes

client/src/components/Page/PageDropdown.vue Outdated Show resolved Hide resolved

martenson added 2 commits July 18, 2023 18:42

use router instead of hardlinks

574f0da

use router-link component for navigation

d586a48

martenson force-pushed the norot branch from 4b95a06 to d586a48 Compare July 18, 2023 17:01

ElectronicBlueberry reviewed Jul 24, 2023

View reviewed changes

client/src/components/Page/PageList.vue Outdated Show resolved Hide resolved

martenson force-pushed the norot branch from d586a48 to 93c219d Compare July 24, 2023 09:18

avoid void

8c5dfb0

martenson force-pushed the norot branch from 93c219d to 8c5dfb0 Compare July 24, 2023 09:19

martenson mentioned this pull request Jul 24, 2023

avoid void #16439

Draft

4 tasks

jmchilton approved these changes Jul 28, 2023

View reviewed changes

martenson merged commit 889b570 into galaxyproject:release_23.1 Jul 28, 2023
14 checks passed

martenson deleted the norot branch July 28, 2023 15:40