[23.1] Fix ordering of data libraries from API #16300

martenson · 2023-06-22T20:40:34Z

plus a race condition and visual indicator/default sort

fixes the issue @jennaj reported

License

I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

seems like a reasonable default

lib/galaxy/managers/libraries.py

mvdbeek · 2023-06-23T14:35:03Z

this wouldn't log in properly locally for me

it is now proper default

martenson · 2023-06-23T20:51:40Z

@mvdbeek yeah it was, it expected unsorted initial render, which I think is wrong

all tests here would also fail for me locally because of weird admin handling, so I adjusted that to standard (?) here: aaeeb08

mvdbeek · 2023-06-24T08:37:10Z

martenson added 3 commits June 22, 2023 13:38

remove the race condition for current user

7786da9

indicate correct sort on library table, saves two clicks

0b289ba

sort list of libraries by lowercase name ascending

08e4df4

seems like a reasonable default

martenson added kind/bug area/UI-UX area/libraries Data libraries labels Jun 22, 2023

martenson added this to the 23.1 milestone Jun 22, 2023

lint

e49d820

jdavcs reviewed Jun 22, 2023

View reviewed changes

lib/galaxy/managers/libraries.py Outdated Show resolved Hide resolved

martenson added 2 commits June 23, 2023 13:48

run properly as admin

aaeeb08

this wouldn't log in properly locally for me

do not click on orting column to show default

cac6d31

it is now proper default

mvdbeek merged commit d5c66b9 into galaxyproject:release_23.1 Jun 24, 2023
38 checks passed

martenson deleted the libsfix branch June 24, 2023 18:45

mvdbeek changed the title ~~[23.1] fix ordering of data libraries from API~~ [23.1] Fix ordering of data libraries from API Jun 28, 2023