Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.1] Fix form builder value handling #16304

Merged
merged 6 commits into from Jun 24, 2023
Merged

[23.1] Fix form builder value handling #16304

merged 6 commits into from Jun 24, 2023

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Jun 23, 2023 •
edited

Fixes #16303. Thanks for reporting this issue @mvdbeek!

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 23.1 milestone Jun 23, 2023
@guerler guerler marked this pull request as ready for review June 24, 2023 07:32
@guerler guerler requested a review from mvdbeek June 24, 2023 07:32
mvdbeek
mvdbeek reviewed Jun 24, 2023
View reviewed changes
lib/galaxy/webapps/galaxy/controllers/dataset.py
@@ -215,7 +215,7 @@ def get_edit(self, trans, dataset_id=None, **kwd):
"name": name,
"label": spec.desc,
"options": attributes.options,
"value": attributes.value if attributes.multiple else [attributes.value],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that if statement looks to be the opposite of what was intended ? i.e cast to array if attributes.multiple is false ... good catch.

@mvdbeek mvdbeek merged commit 42e3d7a into galaxyproject:release_23.1 Jun 24, 2023
38 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Jun 24, 2023

Thanks for the quick fix @guerler!

@mvdbeek mvdbeek mentioned this pull request Jun 24, 2023
Closed
@guerler guerler deleted the fix_formbuilder branch August 9, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek left review comments

Assignees
No one assigned
Labels
area/UI-UX area/util kind/bug
Projects
None yet
Milestone
23.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guerler @mvdbeek