Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Include workflow invocations in default activity #16338

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jun 29, 2023

Screenshot 2023-06-29 at 10 43 24

also adjusts the title to Workflow Invocations and changes the help text to refer to workflow runs.
Maybe we should at least partially favor workflow runs or workflow executions over invocations, since that is probably better known to users.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek marked this pull request as ready for review June 29, 2023 10:25
@github-actions github-actions bot added this to the 23.2 milestone Jun 29, 2023
@hexylena
Copy link
Member

workflow runs or workflow executions

yeah definitely! it's likely to be a lot more easily understood. Either of these is a lot better and more easily comprehended.

@dannon dannon merged commit e5197a4 into galaxyproject:release_23.1 Jun 29, 2023
16 checks passed
@dannon dannon modified the milestones: 23.2, 23.1 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants