Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Make tags in public histories read-only #16348

Conversation

davelopez
Copy link
Contributor

This is part of #16339 as a quick fix to avoid free for all tagging in public histories from the UI. It also makes the tags' functionality consistent with other lists or grids.

The underline issue of checking for item ownership when manipulating tags seems to be more involved and will be resolved or discussed in #16339

How to test the changes?

  • Instructions for manual testing are as follows:
    • Go to public histories and try to edit tags on public histories that you don't own.
    • It shouldn't be possible.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez davelopez added this to the 23.1 milestone Jun 30, 2023
@davelopez davelopez mentioned this pull request Jun 30, 2023
25 tasks
@mvdbeek mvdbeek merged commit 4d4f87b into galaxyproject:release_23.1 Jun 30, 2023
15 checks passed
@davelopez davelopez deleted the 23.1_make_public_histories_tags_readonly branch June 30, 2023 13:18
@martenson
Copy link
Member

thanks @davelopez !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants