[23.1] Fix workflow invocation detail reactivity #16369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes reactivity of the composable when the workflow isn't already in the store, e.g. when looking at the details component loaded after submitting a workflow.
mvdbeek
force-pushed
the
workflow_invocation_detail_fix
branch
from
a61f8c5
to
50d5ea5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run a workflow from the submission screen without first populating the store by loading workflow instances through the invocation menu you would notice that the "steps" tabs panel is missing (to reproduce click "Run" from the workflow editor). I think the computed ensures a that the store return value is tracked as a reactive dependency (as opposed to using the ref alone), but would appreciate confirmation that that is indeed what fixes the bug.
How to test the changes?
(Select all options that apply)
License