Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Disable console instead of dropping #16372

Merged

Conversation

ElectronicBlueberry
Copy link
Member

We are currently dropping all console commands from production builds.
This is desirable, as console commands can cause performance impacts and memory leaks.

However, it can make looking into issues on production a lot harder. Some useful vue errors, warning logs, or custom logs which could help in quickly pinning down an issue may be hidden.

This PR disables the console instead of dropping it, by overriding each key of the global console object with empty functions. It also adds the global functions enableDebugging() and disableDebugging(), which can be run from the console.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Jul 6, 2023
@dannon
Copy link
Member

dannon commented Jul 6, 2023

+1, I actually ran into a situation recently where I ended up running a local client with CHANGE_ORIGIN just to debug. Powerful tool, but just enabling the console might have saved me some trouble.

@dannon dannon merged commit 7621518 into galaxyproject:release_23.1 Jul 6, 2023
15 checks passed
@galaxyproject galaxyproject deleted a comment from github-actions bot Jul 24, 2023
@dannon dannon modified the milestones: 23.2, 23.1 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants