[23.1] Fix webhook release note seen pin #16446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
reviewed
Jul 24, 2023
| // If we're at a deployed release candidate, just mark it seen and show | ||
| // the previous notes if someone clicks the link. RC notes won't exist. | ||
| if (Galaxy.config.version_minor.startsWith("rc")) { | ||
| // If we, for whatever reason, need to do this again just add |
There was a problem hiding this comment.
I guess we should have broken this down into major, minor, micro and suffix, or just return the complete version ... whatever is going to replace the webhook is likely also going to have to deal with this ?
There was a problem hiding this comment.
So moving forward I expect it'll just be an explicit helper script or a button in the admin notifications UI to 'send release notification' that an admin will be able to get hands on and customize prior to sending.
mvdbeek
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16375
How to test the changes?
(Select all options that apply)
License