Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tox startup (run.sh) test and test on OS X and linux #1649

Merged
merged 4 commits into from Feb 8, 2016

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Feb 2, 2016

This fetches @jmchilton's sqlite template, runs common_startup.sh and run.sh, and checks that curl can contact galaxy. On the .travis.yml side, this test is run on linux and os x.

@martenson
Copy link
Member

very nice @mvdbeek !

@jmchilton
Copy link
Member

What a wonderful idea, this is awesome.

It is unrelated to this PR so feel free to ignore the request, but I will grant bonus points if you update the travis matrix to run the py27 unit tests under Mac OS X also.

@galaxybot galaxybot added this to the 16.04 milestone Feb 2, 2016
@mvdbeek
Copy link
Member Author

mvdbeek commented Feb 2, 2016

Yay! Bonus Points !! 💰
The startup test on osx is supposed to fail ( Issues #1633 / #1640).

@mvdbeek
Copy link
Member Author

mvdbeek commented Feb 2, 2016

@natefoo is it to be expected that common_start.sh / run_tests.sh are still fetching pip-8.0.2+gx1 ?
https://travis-ci.org/mvdbeek/galaxy/jobs/106509804#L2522

@natefoo
Copy link
Member

natefoo commented Feb 2, 2016

Yes, until #1652 is merged and release_16.01 is merged back to dev. After that, if you rebase this PR it should fetch 8.0.2+gx2 and the startup test on OS X should pass.

@mvdbeek
Copy link
Member Author

mvdbeek commented Feb 2, 2016

Alright, thanks!

@mvdbeek
Copy link
Member Author

mvdbeek commented Feb 2, 2016

Seems to work now. Should I rebase anything?
Also, I'm not sure anymore that testing run.sh is really necessary, given that #1640 would have been caught by py27-unit testing on os x.

@jmchilton
Copy link
Member

@mvdbeek I still think exercising the recent migrations and a full start of the server is a good exercise. I like this the way it is.

@mvdbeek
Copy link
Member Author

mvdbeek commented Feb 3, 2016

@jmchilton
Seeing issue #1563 made me think that perhaps testing run.sh on a bunch of docker images for common distributions wouldn't be the worst idea either ... but it will slow down testing.
Perhaps doing docker-based testing on wercker would be an option?

@mvdbeek
Copy link
Member Author

mvdbeek commented Feb 6, 2016

@jmchilton
From my side this would be ready for merging.
More testing is probably worthwile (I saw at least one OS X related failure with run_tests.sh -framework (awk having slightly different options ...), but that would be a new PR.

jmchilton added a commit that referenced this pull request Feb 8, 2016
Add tox startup (run.sh) test and test on OS X and linux
@jmchilton jmchilton merged commit faeedd6 into galaxyproject:dev Feb 8, 2016
@mvdbeek mvdbeek deleted the add_startup_test branch February 10, 2016 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants