Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that required text parameters need a validator #16538

Merged
merged 1 commit into from Aug 10, 2023

Conversation

bernt-matthias
Copy link
Contributor

Just stumbled over #15491 and found that it deserves a bit more prominent docs.

In my experiments, I found that tools with mandatory text parameters (without validator) can be executed and the parameter is still treated as "" in cheetah. Is the latter a bug? When reading #15491 I got the impression that it should be None.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Aug 10, 2023
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvdbeek mvdbeek changed the title more explicit docs for mandatory text parameters Document that required text parameters need a validator Aug 10, 2023
@mvdbeek mvdbeek merged commit d35ce3d into galaxyproject:dev Aug 10, 2023
40 checks passed
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@bernt-matthias bernt-matthias deleted the doc/text-mandatory branch August 10, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants