Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Ignore errors with user-set job resources #16579

Merged
merged 2 commits into from Aug 23, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Aug 21, 2023

Fixes
https://sentry.galaxyproject.org/share/issue/735cef91223e42888ff9bc54ec93c2cb/, which is a problem that happens when a workflow with resource parameters is imported from another Galaxy instance, or when we change the available resource parameters and the selection becomes invalid.

Medium-term we need to stop doing this completely IMO and work with more abstract job requirements IMO, as this is a big barrier to transfer workflows from instance to instance and having them just work.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Fixes
https://sentry.galaxyproject.org/share/issue/735cef91223e42888ff9bc54ec93c2cb/,
which is a problem that happens when a workflow with resource parameters
is imported from another Galaxy instance, or when we change the
available resource parameters and the selection becomes invalid.

Medium-term we need to stop doing this completely IMO and work with more
abstract job requirements IMO, as this is a big barrier to transfer
workflows from instance to instance and having them just work.
Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate this - shouldn't we just make sure they aren't imported/exported? I thought we had code to do that - I get it might have bugs in it but it seems the right approach. Approving the PR though because I trust you.

@mvdbeek
Copy link
Member Author

mvdbeek commented Aug 23, 2023

shouldn't we just make sure they aren't imported/exported?

of course we should also do that, but this wouldn't fix workflows users have already imported, or that the admins broke by changing the resource param definition. I'd be happy to do that, but I don't know if it is reasonable that downloading and re-uploading a workflow changes removes the resource parameter selection, that seems ... suboptimal as well ?

@mvdbeek mvdbeek merged commit 66ec43c into galaxyproject:release_23.1 Aug 23, 2023
38 checks passed
@dannon dannon modified the milestones: 23.2, 23.1 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants