Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Fix replacement parameters for subworkflows. #16592

Merged
merged 1 commit into from Aug 25, 2023

Conversation

jmchilton
Copy link
Member

@jmchilton jmchilton commented Aug 24, 2023

Fixes #16528.

How to test the changes?

(Select all options that apply)

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Copy link
Member

mvdbeek commented Aug 25, 2023

The test errors look to be unrelated, something odd with container resolution, I'ld restart them just in case

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks a lot @jmchilton!

@jmchilton jmchilton marked this pull request as ready for review August 25, 2023 17:33
@jmchilton jmchilton merged commit d00e01e into galaxyproject:release_23.1 Aug 25, 2023
39 of 40 checks passed
@github-actions github-actions bot added this to the 23.2 milestone Aug 25, 2023
@dannon dannon modified the milestones: 23.2, 23.1 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants