[23.0] Fixes for extra files handling and cached object stores #16595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
force-pushed
the
download_directory_fix
branch
from
bbd11d1
to
fec5040
Compare
natefoo
approved these changes
Aug 25, 2023
mvdbeek
force-pushed
the
download_directory_fix
branch
3 times, most recently
from
c2be4aa
to
678efa3
Compare
…t cache can be repopulated
seems needed for docker volume strings (an empty variable would lead to `-v "::rw"` which causes `docker: invalid spec: ::rw: empty section between colons.`)
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
mvdbeek
force-pushed
the
download_directory_fix
branch
from
678efa3
to
99ffa0e
Compare
|
Amazing - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outputs_to_working_directoryis offHow to test the changes?
(Select all options that apply)
License