Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Optimize getting current user session #16604

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Aug 27, 2023

We get all user session when logging in, this isn't necessary and does show up in a memray trace. I don't think it's a leak, but this is going to be more efficient.

Screenshot 2023-08-27 at 11 43 14

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

We get all user session when logging in, this isn't necessary and does
show up in a memray trace. I don't think it's a leak, but this is going
to be more efficient.
@mvdbeek mvdbeek marked this pull request as ready for review August 28, 2023 09:45
@github-actions github-actions bot added this to the 23.2 milestone Aug 28, 2023
@jmchilton
Copy link
Member

Shouldn't these optimizations target dev?

@mvdbeek
Copy link
Member Author

mvdbeek commented Aug 28, 2023

Yes and no, we do want to run it on usegalaxy.org to see if it makes a difference, but if it doesn't fix the linear increase it could just go to dev, yes.

@dannon dannon merged commit 607a407 into galaxyproject:release_23.1 Aug 29, 2023
38 checks passed
@dannon dannon modified the milestones: 23.2, 23.1 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants