[23.1] Reload toolbox after forking when using --preload
#16620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding gunicorn workers or restarting workers the new workers need to load up the current toolbox, as it may have changed from when the master process became ready. To test this, start gunicorn with `--preload` and `--max-requests 50`. After the instance has booted change the tool version in a single tool. The tool watcher will pick this up and you get the new tool version. Now trigger the worker replacement by making 50 requests. Without this commit you would get the old version.
We only load the hashes in the config watcher thread, so the initial hashes are not available. I assume there's no sudden modtime changes on production instances that would make this invalid.
mvdbeek
changed the title
--preload--preload
mvdbeek
changed the title
--preload--preload
|
Your patience for these deployment things is impressive - I appreciate you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding gunicorn workers or restarting workers the new workers need
to load up the current toolbox, as it may have changed from when the
master process became ready.
To test this, start gunicorn with
--preloadand--max-requests 50.After the instance has booted change the tool version in a single tool.
The tool watcher will pick this up and you get the new tool version.
Now trigger the worker replacement by making 50 requests. Without
this PR you would get the old version.
How to test the changes?
(Select all options that apply)
License