Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency update GitHub workflow #16639

Merged
merged 3 commits into from Sep 3, 2023

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Sep 2, 2023

Follow-up on #16638 , which broke the lint requirement update script:

  • Use poetry to generate the pinned typecheck requirements. The generation of the pinned lint requirements needs to remain separate because flake8 requires importlib-metadata 4.2, while the Galaxy's core dependencies depend on importlib-metadata 4.13.
  • Install both Python 3.7 and 3.8 in the dependency update workflow to generate both pinned lint requirements (using pip freeze under Python 3.7) and core/dev/typecheck requirements (using poetry under Python 3.8).

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Fix the following warning:

Warning: In a future version of Poetry, PyPI will be disabled
automatically if at least one custom primary source is configured.
In order to avoid a breaking change and make your pyproject.toml
forward compatible, add PyPI explicitly via 'poetry source add pypi'.
By the way, this has the advantage that you can set the priority of
PyPI as with any other source.
Follow-up on commit d604bff .

Drop caching of pip directory for this workflow.
@github-actions github-actions bot added this to the 23.2 milestone Sep 2, 2023
@mvdbeek mvdbeek merged commit 9877fed into galaxyproject:dev Sep 3, 2023
42 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Sep 3, 2023

Thank you @nsoranzo!

@nsoranzo nsoranzo deleted the dependencies_wf_py3.8 branch September 3, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants