Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Only show 'edit' on published pages when viewer is the owner. #16680

Merged
merged 1 commit into from Sep 13, 2023

Conversation

dannon
Copy link
Member

@dannon dannon commented Sep 12, 2023

Sharing pages doesn't grant edit permissions so I don't think we don't have to look at roles/etc. We'd generally prefer using encoded userId for comparison, but that's not available here for the page and actual security is enforced in the API, so this just displays (or not) the UI.

Following up in dev with an update to script setup+ts.

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

pages don't grant edit permissions, so this is good enough.  All actual
security is enforced in the API, so this just displays (or not) the
UI.
@dannon dannon marked this pull request as ready for review September 12, 2023 14:37
@github-actions github-actions bot added this to the 23.2 milestone Sep 12, 2023
@mvdbeek mvdbeek merged commit 5f4107d into galaxyproject:release_23.1 Sep 13, 2023
19 of 20 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Sep 13, 2023

Thank you @dannon!

@dannon dannon modified the milestones: 23.2, 23.1 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants