Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.1] Fix regex validation for global inline flags #16683

Merged
merged 1 commit into from Sep 13, 2023
Merged

[23.1] Fix regex validation for global inline flags #16683

merged 1 commit into from Sep 13, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Sep 13, 2023

Fixes #16676

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Sep 13, 2023
@mvdbeek mvdbeek force-pushed the use_more_lenient_regex_library_to_allow_inline_global_regex_flags branch from 23ed680 to 63442d1 Compare September 13, 2023 10:01
davelopez
davelopez approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@davelopez davelopez mentioned this pull request Sep 13, 2023
Closed
@mvdbeek
Copy link
Member Author

mvdbeek commented Sep 13, 2023

The converter test will be fixed by switching to --biocontainers, so not related. I've reported the UCSC table browser issue upstream and the other selenium error is known to be flaky.

@mvdbeek mvdbeek merged commit 5d6a11a into galaxyproject:release_23.1 Sep 13, 2023
36 of 39 checks passed
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@nsoranzo nsoranzo deleted the use_more_lenient_regex_library_to_allow_inline_global_regex_flags branch September 13, 2023 11:36
@mvdbeek mvdbeek mentioned this pull request Sep 13, 2023
Merged
4 tasks
@dannon dannon modified the milestones: 23.2, 23.1 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/dependencies area/packaging area/testing area/tool-framework kind/bug
Projects
None yet
Milestone
23.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mvdbeek @davelopez @dannon @nsoranzo