Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start auditing contributors to check for relicensing #16708

Draft
wants to merge 26 commits into
base: dev
Choose a base branch
from

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Sep 18, 2023

I'm checking to see which contributors have not agreed to the retroactive MIT licensing request, and documenting the evidence for those who did.

There are 631 unique author name/email addresses in the git history, so help is appreciated!

Please comment in this PR if you are working on this, to avoid duplication; state the alphabet letter you are working on, or some other indication

My process

  1. Browse the author list and pick up where I left off: git log --pretty="%aN <%aE>" | sort -u | less
  2. Put an entry in the .mailmap even if there is only one variant for that contributor
  3. Add other variants to the .mailmap as they are found. Use the extended version (source name and email address) if the email address is generic, like <user@user-MacBook-Air.local>
  4. Check git log for the most recent commit, and look it up at https://github.com/galaxyproject/galaxy/commit/${HASH} to get the GitHub username. Clicking on the username should bring up a list of all their contributions to this repo: https://github.com/galaxyproject/galaxy/commits?author=mr-c
  5. If there is a post 2021-04-07 commit, click through to find the PR and ensure the the MIT retroactive license grant box was checked. Add the contributor's GitHub username, primary email address, and that URL to the first table in doc/relicensing/status.txt
  6. If there isn't easy evidence for MIT re-licensing, then add their details to the second table in doc/relicensing/status.txt

Note: some contributors might be left out of the mailmap for privacy reasons

  • IMPORTANT remove .mailmap before merging

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mr-c
Copy link
Contributor Author

mr-c commented Sep 18, 2023

I'm going to pause for now, I'll resume work on the As later

@nsoranzo
Copy link
Member

@mr-c I've started from Z upwards, just pushed a commit, hopefully no conflicts with your work.

@mr-c
Copy link
Contributor Author

mr-c commented Sep 25, 2023

Thank you @nsoranzo ; any updates to doc/relicensing/status.txt, or are you just doing a cleanup of the contributors list (also still helpful!)

@nsoranzo
Copy link
Member

I am focusing on the mailmap currently.

@hexylena
Copy link
Member

@natefoo and I have been in contact with @Slugger70's family regarding the relicensing of his contributions. We requested the agreement of someone who inherited these contributions, included a copy of the license and background information on why we were requesting it, and have an emailed confirmation from his son:

Yes, I agree that my father, Simon Gladman's historical contributions can be relicensed under MIT

mr-c and others added 4 commits October 13, 2023 14:16
In a private email, Simon Gladman's heirs have approved of relicensing all of
his contributions to the Galaxy project under the MIT license.

Credit to Helena Rasche (@hexylena) for asking the family in a kind and
sensitive manner. RIP Simon, you are missed and will not be forgotten.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants