Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Fix job search query #16714

Merged
merged 1 commit into from Sep 20, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Sep 20, 2023

We need to add the dataset_id to the select here (just like in the cases below) ... just calling query.add_columns() doesn't change the query in place.

Fixes the new error @bwlang ran into in https://help.galaxyproject.org/t/i-tried-to-run-a-new-workflow-but-it-stopped-scheduling-at-some-point-seems-like-a-better-error-message-is-in-order/10719

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

We need to add the dataset_id to the select here (just like in the cases
below) ... just calling query.add_columns() doesn't change the query in
place.

Fixes the new error @bwlang ran into in https://help.galaxyproject.org/t/i-tried-to-run-a-new-workflow-but-it-stopped-scheduling-at-some-point-seems-like-a-better-error-message-is-in-order/10719
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@martenson martenson merged commit 551fabd into galaxyproject:release_23.1 Sep 20, 2023
36 of 38 checks passed
@dannon dannon modified the milestones: 23.2, 23.1 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants