Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include tool stdout/stderr in HDA info #16730

Merged
merged 1 commit into from
May 15, 2024

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Sep 22, 2023

Previously, job stdout and stderr would also be included, which is not typically relevant and can be confusing to users. Job stdout/stderr are still preserved in their own columns and in bug reports.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@natefoo natefoo marked this pull request as ready for review September 22, 2023 18:15
@github-actions github-actions bot added this to the 23.2 milestone Sep 22, 2023
@mvdbeek
Copy link
Member

mvdbeek commented Sep 22, 2023

typically relevant and can be confusing to users

and yet it's sometimes the only thing we got. This should probably be accompanied by a client side change that pulls these messages in from the job ?

@natefoo
Copy link
Member Author

natefoo commented Sep 22, 2023

We're not losing them, we're just not displaying them in the HDA info box to users. They are still visible on the bug report form. But yeah, they probably ought to be included on the dataset info page.

@mvdbeek
Copy link
Member

mvdbeek commented Sep 22, 2023

And in the dataset info, but users rarely go there and we do a terrible job hiding the important stuff in a lot of details.

@mvdbeek mvdbeek modified the milestones: 23.2, 24.0 Dec 19, 2023
@jdavcs jdavcs modified the milestones: 24.0, 24.1 Mar 1, 2024
@jdavcs
Copy link
Member

jdavcs commented Mar 1, 2024

Bumping to 24.1, as discussion still open.

@dannon
Copy link
Member

dannon commented May 14, 2024

Rebased for a test rerun, this is a good change -- we may just need to update tests if anything.

@dannon dannon merged commit 919bf37 into galaxyproject:dev May 15, 2024
52 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants