Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for shared usage between TS and galaxy apps #16746

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Sep 26, 2023

This is rather unfortunate, but for now I don't see any other way around this other than removing typing of method params. The model may belong to galaxy or tool shed (both User and APIKeys), and the only way of adding this would be to import from tool shed. (ref 09c2efc#r128430531)

If we have to share this code with tool shed, I think it belongs in a separate utility library shared across both galaxy and tool shed, not in galaxy's managers.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added kind/bug area/toolshed area/auth Authentication and authorization labels Sep 26, 2023
@jdavcs jdavcs added this to the 23.2 milestone Sep 26, 2023
@jmchilton
Copy link
Member

The tool shed branch has some small typing tweaks to get us toward some protocols that are shared but I agree the current situation around shared code is problematic. The typing is just foregrounding errors we've always had. Certainly the manage taking a Base app that is shared with the tool shed and not the Galaxy app is... a step forward from just using an untyped trans.app everywhere.

Thanks for the fix.

Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@jmchilton jmchilton merged commit b180b79 into galaxyproject:dev Sep 26, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auth Authentication and authorization area/toolshed kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants