move the email and username redacting from the role loop #16805

martenson · 2023-10-06T18:45:19Z

I guess this worked because user is guaranteed to have a role?

How to test the changes?

(Select all options that apply)

I've included appropriate automated tests.
This is a refactoring of components with existing test coverage.
Instructions for manual testing are as follows:
1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

I guess this worked because user is guaranteed to have a role?

mvdbeek · 2023-10-09T14:52:16Z

I guess, but could you also backport this to 23.1 ?

remove the email and username redacting frmo the role loop

ed519e6

I guess this worked because user is guaranteed to have a role?

martenson added kind/bug area/backend labels Oct 6, 2023

github-actions bot added this to the 23.2 milestone Oct 6, 2023

mvdbeek merged commit 985c181 into galaxyproject:dev Oct 9, 2023
37 of 41 checks passed

martenson mentioned this pull request Oct 9, 2023

[23.1] move the email and username redacting from the role loop #16820

Merged

4 tasks

martenson deleted the purge-unampass branch October 13, 2023 17:27