Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.1] Fix up local tool version handling #16836

Merged
merged 3 commits into from Oct 12, 2023
Merged

[23.1] Fix up local tool version handling #16836

merged 3 commits into from Oct 12, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Oct 12, 2023 •
edited

This is the other part of https://help.galaxyproject.org/t/workflow-documentation-via-link/10927/3 and loads up the right tool version in the first place.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Get correct tool version in workflow preview
5f1471e 
And remove the step.type is None condition, which I don't think can
happen and even if it can, would have already failed at the module
inection in module_factory.from_workflow_step.
@mvdbeek
Fix tool version switching for local tools
519066a 
They don't have the version in the tool id, so we need to explicitly
include tool_version.
@github-actions github-actions bot added this to the 23.2 milestone Oct 12, 2023
@mvdbeek mvdbeek changed the title [23.1] Fix up tool version handling [23.1] Fix up local tool version handling Oct 12, 2023
@dannon dannon merged commit 4a397b1 into galaxyproject:release_23.1 Oct 12, 2023
42 checks passed
@mvdbeek
Copy link
Member Author

mvdbeek commented Oct 13, 2023

@kysrpex any chance you could update usegalaxy.eu with this ? The user that opened https://help.galaxyproject.org/t/workflow-documentation-via-link/10927/3 is using usegalaxy.eu

@kysrpex
Copy link
Contributor

kysrpex commented Oct 17, 2023

@kysrpex any chance you could update usegalaxy.eu with this ? The user that opened https://help.galaxyproject.org/t/workflow-documentation-via-link/10927/3 is using usegalaxy.eu

Someone else already merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannon dannon dannon approved these changes

Assignees
No one assigned
Labels
area/API area/UI-UX area/workflows kind/bug
Projects
None yet
Milestone
23.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvdbeek @kysrpex @dannon