Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Improve invocation error reporting #16917

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Oct 25, 2023

Turns many possible Invocation scheduling failed because an unexpected failure occurred. into Invocation scheduling failed because an unexpected failure occurred at step 2: 'Relabel mapping file contains incorrect number of identifiers'.

It's not technically a bug, but without this users will have an unnecessarily hard time figuring out what is wrong with their workflows run.

This is an example for an apply rules step going wrong because the input dataset is in a failed state:
Screenshot 2023-10-25 at 12 03 34

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek marked this pull request as ready for review October 25, 2023 11:27
@mvdbeek mvdbeek requested a review from a team October 25, 2023 11:27
@github-actions github-actions bot added this to the 23.2 milestone Oct 25, 2023
@mvdbeek
Copy link
Member Author

mvdbeek commented Oct 25, 2023

quay.io is throwing a fit, those errors are not related to the PR.

Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thanks!

@mvdbeek mvdbeek merged commit cd93598 into galaxyproject:release_23.1 Oct 25, 2023
39 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants