Persistent toggle sections of job info #16983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannon
changed the title
dannon
force-pushed
the
persistent-toggle-section
branch
from
2eb374c
to
5f5a18b
Compare
|
I'm going to rework the prop here so we don't need separate collapsible/collapsed bits. |
dannon
force-pushed
the
persistent-toggle-section
branch
from
e6961ce
to
47212d7
Compare
dannon
force-pushed
the
persistent-toggle-section
branch
from
d983bf9
to
67b0b01
Compare
toggled state of particular sections in the UI.
…aving separate 'collapsible' and 'collapsed' props.
Co-authored-by: Laila Los <44241786+ElectronicBlueberry@users.noreply.github.com>
…n. The click bubbles up to the parent, so the header is fully clickable and the button is tab navigable for accessibility.
dannon
force-pushed
the
persistent-toggle-section
branch
from
67b0b01
to
805b675
Compare
|
Shifted this to use the first column when in a separator, and it's keyboard-accessible in both configurations now. |
ahmedhamidawan
approved these changes
Apr 29, 2024
Co-authored-by: Ahmed Hamid Awan <qe66653@umbc.edu>
|
Thank you! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persistent section toggles to address #16441. Adds a basic keyed persistent toggle composable, integrates it with our Heading component (though you could use it wherever), and sets two sections to use it as a test.
Considering dropping the caret and just having the header be clickable as the toggle in this case, with an appropriate tooltip.
How to test the changes?
(Select all options that apply)
License